Google Un-Proffesional?!

by AlexK » Thu, 30 Apr 2009 05:22:19 GMT


Sponsored Links
 Hi,

Second time the same problem: latest sources from MASTER branch have
compilation error. (QEMU compilation failure).

I think problem is in way how Google engineers committing own code
into GIT repository.

Please fill the difference: other developers publish code on GitWeb
then waiting approve from at least two code reviewers and only after
that Google engineer MERGE our changes with MASTER branch... Looks
like Google developers simply commit own changes into GIT without
passing similar loop as other developers do.

It's OK, but at least check those changes before making them MERGED
into MASTER branch. With all respect to all developers, but such
behavior is not a good professional move.

P.S. I don't want to blame anyone, but I want to notify Google Android
Team that other developers watching them and expecting highly
professional behavior. I hope google team will find proper solution
for that "development cycle" problem.

P.P.S. sorry for bad English.

Thanks

--~--~---------~--~----~------------~-------~--~----~



Google Un-Proffesional?!

by Romain Guy » Thu, 30 Apr 2009 05:32:13 GMT


 Hi,

All commits made by members of the Android team follow a very similar
process. No code is checked  in without code review.






-- 
Romain Guy
Android framework engineer
romain...@android.com

Note: please don't send private questions to me, as I don't have time
to provide private support.  All such questions should be posted on
public forums, where I and others can see and answer them

--~--~---------~--~----~------------~-------~--~----~


Sponsored Links


Google Un-Proffesional?!

by Jean-Baptiste Queru » Thu, 30 Apr 2009 05:32:27 GMT


 We can't test on every possible version of every possible environment.
The file in question compiles for us on all platforms (the 1.5_r1 SDK
was built with that exact source code).

All the changes are reviewed individually and automatically built for
each target platform. And we did explicitly check that the recent
open-source pushes were building fine for linux and MacOS.

My guess: you're not running Ubintu 8.0.4.

JBQ






-- 
Jean-Baptiste M. "JBQ" Queru
Android Engineer, Google.

Questions sent directly to me that have no reason for being private
will likely get ignored or forwarded to a public forum with no further
warning.

--~--~---------~--~----~------------~-------~--~----~



Google Un-Proffesional?!

by AlexK » Thu, 30 Apr 2009 05:57:56 GMT


 look's like something alway missed...

please understand my skepticism on this, fix on compilation problem
can be caught only under Linux Ubuntu, under MacOS everything is ok
(according to posts from other developers and changes required in
makefile.android for QEMU for fixing that problem)...

With all respect but this is second time with me when I catch un-
compilable sources in MASTER branch.




--~--~---------~--~----~------------~-------~--~----~



Google Un-Proffesional?!

by Dianne Hackborn » Thu, 30 Apr 2009 06:02:13 GMT


 Please take this off android-developers and to android-porting.








-- 
Dianne Hackborn
Android framework engineer
hack...@android.com

Note: please don't send private questions to me, as I don't have time to
provide private support, and so won't reply to such e-mails.  All such
questions should be posted on public forums, where I and others can see and
answer them.

--~--~---------~--~----~------------~-------~--~----~



Google Un-Proffesional?!

by AlexK » Thu, 30 Apr 2009 06:04:45 GMT


 I especially create clean platform setup for Android builds. And do
not use platform for any other tasks.
All environment setup I did according to published by Google
documentation. So I expect 99% match on requirements for building
Android OS.

My OS: Linux Ubuntu x86 i386 v9.04

Looks like 1.5 release was very hard and android team tiered.:)

Thanks,
Good Luck




--~--~---------~--~----~------------~-------~--~----~



Google Un-Proffesional?!

by Nick Pelly » Thu, 30 Apr 2009 06:37:18 GMT


 i Alex,

This patch to external/qemu should fix you up:

Author: Nick Pelly <npe...@google.com>
Date: Fri Apr 24 15:28:40 2009 -0700

Fix build for platforms where deprecated symbol EAI_NODATA is not
defined.

diff --git a/sockets.c b/sockets.c
index fa1f39d..be40a56 100644
--- a/sockets.c
+++ b/sockets.c
@@ -634,7 +634,9 @@ sock_address_init_resolve( SockAddress* a, const char*
hostname, uint16_t por
err = EHOSTDOWN;
break;

+#ifdef EAI_NODATA
case EAI_NODATA:
+#endif
case EAI_NONAME:
err = ENOENT;
break;


I hit the same problem on Ubuntu 9.04. I'll work on expediating this patch
into open source.

Now a couple of comments about your approach:

If you are interested in getting your build working, then android-porting
would have been the right list. And you should have posted the exact
compliation failure. Not posting the failure message makes it look like you
are searching for an oppurtunity to complain rather than an oppurtunity to
contribute. You are lucky in this case that I fixed (what I think is your
problem) just recently and happened to read this post.

Your trigger-happy claims that Google are acting unprofessionally give the
appearance that you are uninformed. Google engineers do go through a code
review loop just as external developers do. In this case the error is
specific to the deprecation of EAI_NODATA in Ubuntu 9.04 which is less than
a week old, and is not indicative of a code review process problem. The fact
that you must have just installed Ubuntu 9.04 should have given a clue as to
where your problems lay!

Nick



On Wed, Apr 29, 2009 at 3:04 PM, AlexK <kucherenko.a...@gmail.com> wrote:


--~--~---------~--~----~------------~-------~--~----~



Other Threads

1. Intent Issue

Hi,

On canceling the call in the Phone App, the Dialtacts Activity is
launched with "Call log" tab selected.

I have written an application that will receive the same intent
(android.intent.action.VIEW) fired by Phone App.

Now on canceling the call it asks me to launch which application :-
default Contact Application or my application.

I want to bypass this popup and want to launch my application.

How can this be achieved?

Regards,
Saurabh

-- 

2. onClick in ListView erratic ?

I've got an ArrayAdaptor to add onClick listeners to items.

The logging in here says it adds them to every item.
Some items that I press seem OK, with others the click is not logged,
and the click goes through to the list (I can see the highlight, but
it doesn't register my button presses).

Any idea what I'm going wrong ?


Heres how I setup my listeners (for buttons with id thumb, play, save
and delete):

        public View getView(int position, View  convertView, ViewGroup
parent) {
                int[] buttons = new int[] { R.id.thumb, R.id.play, R.id.save,
R.id.delete};
                if (convertView != null) for(int buttonId: buttons) {
                        View button = convertView.findViewById(buttonId);
                        if (button != null) {
                                button.setClickable(true);
                                button.setFocusable(true);
                                button.setOnClickListener(this);


                                Log.i("Add Listener", "" + (Video) 
getItem(position));
                                button.setTag(getItem(position)); // Add Video 
as tag
                        }
                }
                return super.getView(position, convertView, parent);
        }

        @Override
        public boolean  areAllItemsEnabled() {
            return true;
        }

        @Override
        public boolean isEnabled(int position) {
                return true;
        }

-- 

3. Creating Multiple User Preference

4. Android Development Tools - Support for Additional JDKs

5. Creating sample sound playing app

6. Emulator capabilities

7. Error Building Android NDK sample "bitmap-plasma"